Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unnecessary_import #173

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Conversation

b4tchkn
Copy link
Contributor

@b4tchkn b4tchkn commented Dec 13, 2021

What does this change?

Add unnecessary_import in ignore_for_title because cause warning from Dart 2.15

@wasabeef wasabeef self-requested a review December 13, 2021 10:14
@wasabeef wasabeef added this to the 4.1.3 milestone Dec 13, 2021
@wasabeef wasabeef linked an issue Dec 13, 2021 that may be closed by this pull request
@wasabeef
Copy link
Member

Please update the test_resources files.

https://github.com/FlutterGen/flutter_gen/tree/main/packages/core/test_resources/actual_data

@b4tchkn b4tchkn force-pushed the fix-unnecessary-import branch from 795b08e to 5ce9119 Compare December 14, 2021 04:26
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #173 (5ce9119) into main (59d7eb7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          19       19           
  Lines         565      565           
=======================================
  Hits          559      559           
  Misses          6        6           
Impacted Files Coverage Δ
packages/core/lib/generators/generator_helper.dart 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d7eb7...5ce9119. Read the comment docs.

@wasabeef
Copy link
Member

Thanks!

@wasabeef wasabeef merged commit 279fdfb into FlutterGen:main Dec 14, 2021
@wasabeef wasabeef mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart linter info about import unnecessary
2 participants